Skip to content

Conversation

@jasonz-dfinity
Copy link
Contributor

All registry mutations should be followed by recertify_registry. Otherwise the response from get_certified_changes_since call would be invalid as the RbTree is out-of-sync from the registry records.

Note that, as of Feb. 9th, 2026, no such proposals are executed or made. As long as this fix gets into the mainnet before any such proposals are made, there won't be any errors. In addition, even if such proposals are executed, we can recover simply by making ANY registry mutaions, including ones that can be called without proposals (e.g. update_node_operator_config_directly)

@jasonz-dfinity jasonz-dfinity requested a review from a team as a code owner February 9, 2026 19:52
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pierugo-dfinity pierugo-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions github-actions bot added the fix label Feb 10, 2026
@jasonz-dfinity jasonz-dfinity added this pull request to the merge queue Feb 11, 2026
Merged via the queue into master with commit 108b253 Feb 11, 2026
121 of 130 checks passed
@jasonz-dfinity jasonz-dfinity deleted the jason/misc-registry-certification branch February 11, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants