feat: replace custom validator with skill-validator CLI#115
Merged
Conversation
- Replace scripts/validate-skills.js with skill-validator check for structure, links, content analysis, and contamination detection - Add scripts/check-project.js for icskills-specific checks (required metadata fields title/category, evaluation file existence) - CI posts a sticky PR comment with the full validation report and emits inline annotations on changed lines - Add LLM quality scoring step to contributor workflow using claude-cli - Add .score_cache to .gitignore - Bump Node.js to 22 (LTS) across CI and deploy workflows - Update CONTRIBUTING.md, CLAUDE.md, and README.md Closes #114
raymondk
approved these changes
Mar 23, 2026
- Detect changed skill directories via git diff against base branch - Run skill-validator and project checks only on affected skills - Skip validation comment when no skills were changed - Add CLI filter support to check-project.js
The reusable _checks.yml needs pull-requests: write for the sticky comment. The caller must grant at least the same permissions.
Skill Validation ReportNo skill files were changed in this PR — validation skipped. |
marc0olo
added a commit
that referenced
this pull request
Mar 24, 2026
The deploy-ic.yml workflow started failing with startup_failure after #115 added pull-requests: write to _checks.yml. The deploy workflow never granted this permission to the reusable workflow call, causing GitHub to reject the workflow at startup. Adds top-level and job-level permissions to match ci.yml.
raymondk
pushed a commit
that referenced
this pull request
Mar 24, 2026
The deploy-ic.yml workflow started failing with startup_failure after #115 added pull-requests: write to _checks.yml. The deploy workflow never granted this permission to the reusable workflow call, causing GitHub to reject the workflow at startup. Adds top-level and job-level permissions to match ci.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #114
scripts/validate-skills.jswithskill-validatorCLI — the reference validator for the Agent Skills specscripts/check-project.jsfor icskills-specific checks (requiredtitle/categorymetadata, evaluation file existence, category typo detection)--provider claude-cli).score_cacheto.gitignoreDependencies
The
--provider claude-clirecommendation in contributor docs depends on agent-ecosystem/skill-validator#43 being merged upstream. CI validation works without it.🤖 Generated with Claude Code