[IMP] Simplify environment variable injection in Helm charts using envFrom#944
Draft
ascalotoru wants to merge 1 commit intodfir-iris:developfrom
Draft
[IMP] Simplify environment variable injection in Helm charts using envFrom#944ascalotoru wants to merge 1 commit intodfir-iris:developfrom
ascalotoru wants to merge 1 commit intodfir-iris:developfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b7bbdfd to
ec389cb
Compare
Replace manual env variable mapping with Kubernetes-native envFrom for both irisapp and irisworker deployments. Supports multiple secrets and improves maintainability of the Helm chart.
ec389cb to
d08b2b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the manual environment variable mapping logic in
the irisapp and irisworker Helm charts with Kubernetes-native
envFromreferences. This allows the deployments to load environment variables
directly from one or more secrets.
Motivation
Previously, only a single secret could be used, and adding or removing
environment variables required modifying the Helm template. Using
envFromsimplifies the templates, improves maintainability, and aligns with
Kubernetes best practices.
Changes
envFrom.envFromSecrets.Benefits