Update skrifa to 0.42#118
Open
rhysd wants to merge 1 commit into
Open
Conversation
rhysd
commented
May 28, 2026
| OutlineGlyphFormat::Glyf => &mut self.glyf_entries, | ||
| OutlineGlyphFormat::Cff | OutlineGlyphFormat::Cff2 => &mut self.cff_entries, | ||
| #[allow(unreachable_patterns)] | ||
| _ => &mut self.other_entries, |
Author
There was a problem hiding this comment.
To keep compatibility with older versions of skrifa OutlineGlyphFormat::Varc variant is not available in this arm and #[allow(unreachable_patterns)] is necessary.
If we can upgrade the lower bound of the skrifa version to >=0.41, <=0.42, this arm can be improved. Please let me know if this is preferred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades
skrifadependency to 0.42. I'm using swash with harfrust. However harfrust depends on more recent version ofread-fonts.This caused a conflict in my app so I could not upgrade harfrust to the latest version and I needed to stick with harfrust 0.5.2. This PR aims to unlock the harfrust version upgrade.
All tests passed. I tried this branch with my app and I didn't find any issues.
The non-trivial change in this branch is that skrifa added
OutlineGlyphFormat::Varcat 0.41.https://docs.rs/skrifa/0.41.0/skrifa/outline/enum.OutlineGlyphFormat.html