feat: surface config errors in hook output with additional context#50
Open
dgerlanc wants to merge 1 commit into
Open
feat: surface config errors in hook output with additional context#50dgerlanc wants to merge 1 commit into
dgerlanc wants to merge 1 commit into
Conversation
When mmi config fails to load, return an ask decision with a helpful error message and additional context directing the user to run 'mmi validate', instead of silently falling back to "not in allow list".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdditionalContextfield toSpecificOutputfor richer hook responsesmmi validate, instead of silently falling back to "command not in allow list"FormatAskWithContext()helper for producing ask output with additional contextTest plan
TestProcessWithResultConfigErrorInOutputvalidates output contains config error info andmmi validatesuggestion