fix(dgraph): remove the dead tls.annotations block from Secret templates - #142
Open
mlwelles wants to merge 1 commit into
Open
fix(dgraph): remove the dead tls.annotations block from Secret templates#142mlwelles wants to merge 1 commit into
mlwelles wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ACL, encryption, and TLS Secret templates stamped
{{ with .Values.*.tls.annotations }}, a key defined nowhere in values.yaml — dead code copied from the TLS secret. Removed from all five Secret templates (alpha secret-acl/enc/tls, zero secret-tls, backups secret). The rendered Secrets are unchanged.Part of splitting #140 into per-area PRs. The change was built and validated on that branch; the merge of all split PRs reproduces #140's tree byte-for-byte. #140 is being closed as superseded.