Skip to content

fix(dgraph): trim the trailing dash when fullname truncates at 24 chars - #144

Open
mlwelles wants to merge 1 commit into
mainfrom
fix-fullname-trailing-dash
Open

fix(dgraph): trim the trailing dash when fullname truncates at 24 chars#144
mlwelles wants to merge 1 commit into
mainfrom
fix-fullname-trailing-dash

Conversation

@mlwelles

Copy link
Copy Markdown

dgraph.fullname trimmed a trailing dash only in the fullnameOverride branch; the default branch left a trailing - when the name truncated exactly at a dash (e.g. a 23-char release name). Added the same trimSuffix "-" to the default branch.

Part of splitting #140 into per-area PRs. The change was built and validated on that branch; the merge of all split PRs reproduces #140's tree byte-for-byte. #140 is being closed as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants