Skip to content

feat(dgraph): add persistentVolumeClaimRetentionPolicy for alpha and zero #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlwelles wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(dgraph): add persistentVolumeClaimRetentionPolicy for alpha and zero #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/dgraph/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ The following table lists the configurable parameters of the `dgraph` chart and
| `zero.persistence.storageClass` | PVC Storage Class for zero volume | `nil` |
| `zero.persistence.accessModes` | PVC Access Mode for zero volume | `['ReadWriteOnce']` |
| `zero.persistence.size` | PVC Storage Request for zero volume | `32Gi` |
| `zero.persistence.persistentVolumeClaimRetentionPolicy` | PVC retention policy for the zero StatefulSet (`whenDeleted`/`whenScaled`, each `Retain` or `Delete`); requires Kubernetes >= 1.27. Unset keeps the Kubernetes default. | _unset_ |
| `zero.nodeSelector` | Node labels for zero pod assignment | `{}` |
| `zero.tolerations` | Zero tolerations | `[]` |
| `zero.resources.requests.memory` | Zero pod resources memory requests | `100Mi` |
Expand Down Expand Up @@ -191,6 +192,7 @@ The following table lists the configurable parameters of the `dgraph` chart and
| `alpha.persistence.storageClass` | PVC Storage Class for alpha volume | `nil` |
| `alpha.persistence.accessModes` | PVC Access Mode for alpha volume | `['ReadWriteOnce']` |
| `alpha.persistence.size` | PVC Storage Request for alpha volume | `100Gi` |
| `alpha.persistence.persistentVolumeClaimRetentionPolicy` | PVC retention policy for the alpha StatefulSet (`whenDeleted`/`whenScaled`, each `Retain` or `Delete`); requires Kubernetes >= 1.27. Unset keeps the Kubernetes default. | _unset_ |
| `alpha.nodeSelector` | Node labels for alpha pod assignment | `{}` |
| `alpha.tolerations` | Alpha tolerations | `[]` |
| `alpha.resources.requests.memory` | Zero pod resources memory request | `100Mi` |
Expand Down
7 changes: 7 additions & 0 deletions charts/dgraph/templates/alpha/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ spec:
app: {{ template "dgraph.name" . }}
release: {{ .Release.Name }}
component: {{ .Values.alpha.name }}
{{- if .Values.alpha.persistence.enabled }}
{{- with .Values.alpha.persistence.persistentVolumeClaimRetentionPolicy }}
persistentVolumeClaimRetentionPolicy:
whenDeleted: {{ .whenDeleted | default "Retain" }}
whenScaled: {{ .whenScaled | default "Retain" }}
{{- end }}
{{- end }}
template:
metadata:
name: {{ template "dgraph.alpha.fullname" . }}
Expand Down
7 changes: 7 additions & 0 deletions charts/dgraph/templates/zero/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ spec:
app: {{ template "dgraph.name" . }}
release: {{ .Release.Name }}
component: {{ .Values.zero.name }}
{{- if .Values.zero.persistence.enabled }}
{{- with .Values.zero.persistence.persistentVolumeClaimRetentionPolicy }}
persistentVolumeClaimRetentionPolicy:
whenDeleted: {{ .whenDeleted | default "Retain" }}
whenScaled: {{ .whenScaled | default "Retain" }}
{{- end }}
{{- end }}
template:
metadata:
name: {{ template "dgraph.zero.fullname" . }}
Expand Down
14 changes: 14 additions & 0 deletions charts/dgraph/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,13 @@ zero:
accessModes:
- ReadWriteOnce
size: 32Gi
## Optionally control PVC lifecycle on StatefulSet deletion (whenDeleted) and
## scale-down (whenScaled). Each is "Retain" (the Kubernetes default) or
## "Delete". Leaving this unset preserves current behavior. Requires
## Kubernetes >= 1.27.
# persistentVolumeClaimRetentionPolicy:
# whenDeleted: Retain
# whenScaled: Retain

## Node labels and tolerations for pod assignment
## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#nodeselector
Expand Down Expand Up @@ -422,6 +429,13 @@ alpha:
- ReadWriteOnce
size: 100Gi
annotations: {}
## Optionally control PVC lifecycle on StatefulSet deletion (whenDeleted) and
## scale-down (whenScaled). Each is "Retain" (the Kubernetes default) or
## "Delete". Leaving this unset preserves current behavior. Requires
## Kubernetes >= 1.27.
# persistentVolumeClaimRetentionPolicy:
# whenDeleted: Retain
# whenScaled: Retain

## Node labels and tolerations for pod assignment
## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#nodeselector
Expand Down