fix(dgraph): correct latent StatefulSet bugs (mount, datadir volume, exec, serviceAccountName) - #148
Open
mlwelles wants to merge 1 commit into
Open
fix(dgraph): correct latent StatefulSet bugs (mount, datadir volume, exec, serviceAccountName)#148mlwelles wants to merge 1 commit into
mlwelles wants to merge 1 commit into
Conversation
…exec, serviceAccountName)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base of the stacked chain. Correct four latent StatefulSet bugs: mount
/dgrapheven when persistence is disabled; remove an inert explicitdatadirvolume that duplicated the volumeClaimTemplates entry;execthe alpha command so SIGTERM reaches Dgraph; routeserviceAccountNamethrough the helper so it never renders empty.volumeClaimTemplatesandspec.selectorare untouched (immutable on update).Part of splitting #140 into per-area PRs. The merge of all split PRs reproduces #140's tree byte-for-byte. #140 is being closed as superseded.