feat(dgraph)!: synthesize the --tls superflag and switch probes to HTTPS when TLS is enabled - #152
Open
mlwelles wants to merge 1 commit into
Open
feat(dgraph)!: synthesize the --tls superflag and switch probes to HTTPS when TLS is enabled#152mlwelles wants to merge 1 commit into
mlwelles wants to merge 1 commit into
Conversation
…TPS when TLS is enabled BREAKING CHANGE: alpha.tls.enabled/zero.tls.enabled now synthesize the --tls superflag from the tls block (internalPort/clientName/clientAuthType) and switch health probes to HTTPS. Remove any --tls from extraFlags. A cert-requiring clientAuthType (REQUIREANY/REQUIREANDVERIFY) with httpGet probes fails rendering; use VERIFYIFGIVEN or exec probes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
alpha.tls.enabled/zero.tls.enablednow synthesize the--tlssuperflag from the tls block (internalPort/clientName/clientAuthType) and switch the health probes toscheme: HTTPS. Remove any hand-set--tlsfromextraFlags. A cert-requiringclientAuthType(REQUIREANY/REQUIREANDVERIFY) with the built-in httpGet probes fails rendering — use VERIFYIFGIVEN or exec probes. Migration notes are in the README.Stacked on
feat-chart-ergonomics; will retarget tomainas lower PRs merge.Part of splitting #140 into per-area PRs. The merge of all split PRs reproduces #140's tree byte-for-byte. #140 is being closed as superseded.