Chrome update wrecked relative paths - #2
Open
iaindooley wants to merge 4 commits into
Open
Conversation
added 3 commits
October 12, 2016 20:04
…or unpacked chrome extensions
…rome that broke relative paths
Owner
|
Hey! I haven't used this for years and I don't really want to keep maintaining it. Do you want to take over? |
…to not need this anymore, either that or the change I made last year was specific to another repo and this change will then break that repo... time will, of course, tell, and upon discovery of that I will be better able to tell how to fix this properly instead of continuing to hack into it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I found that some update in Chrome broke the relative paths which used to Just Work(TM).
I couldn't find anywhere in the code where you were actually setting a base path -- it appears that previously chrome just automatically dealt with all the various relative paths ...
Anyway I added in code to detect what the base path actually is by assuming that the html base file is in a "sibling" directory from where the current document resides.
This isn't as elegant as it was before -- perhaps you have a better solution because before you could just include anything from anywhere and it all just seemed to work.
I have only updated the .js file in fragmentify-ext/ i'm not sure that the others need it.
Let me know what you think!