Rusted Moss: Fix unit test & generation failures - #11
Open
kingdragonite55 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes the
test_entrance_connection_stepsunit test failure and eliminates generation failures.Deleting the DLC locations in the
generate_earlystage was causing the unit test failure, and could cause generation issues or failures if there were multiple Rusted Moss players in a multiworld. It may be possible to change the code so that both of these issues are avoided, but leaving the DLC locations out entirely until they are implemented is a much easier solution.For the character check, raising a
ValueErrordirectly is not recommended. It is instead recommended when a user's YAML settings are invalid to raise anOptionError, so I have changed it to that.How was this tested?
I ran all of the standard AP unit tests and none failed. Using Eijebong's APWorld fuzzer to do a test of 5000 generations, the latest release fails 4996/5000 generations, and this PR fails 0/5000.
If this makes graphical changes, please attach screenshots.
N/A