Skip to content

feat(slice-032): complete audit remediation — export status close button + verification #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgtalbug merged 2 commits into from
May 30, 2026
Merged

feat(slice-032): complete audit remediation — export status close button + verification #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fdeabd
feat(032): add export status close button and verify implementation
dgtalbug May 30, 2026
98fc5c1
fix(032): resolve CodeRabbit findings - ARIA semantics and accessibility
dgtalbug May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/extension/src/webview/components/MermaidPreviewPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,19 @@ export function MermaidPreviewPanel({
: styles.exportWorking
}
role={exportStatus.type === "error" ? "alert" : "status"}
aria-live={exportStatus.type === "error" ? undefined : "polite"}
>
Comment thread
coderabbitai[bot] marked this conversation as resolved.
{exportStatus.message}
<span>{exportStatus.message}</span>
{exportStatus.type !== "working" && (
<button
type="button"
onClick={() => setExportStatus({ type: "idle" })}
aria-label="Close export status message"
className={styles.statusCloseButton}
>
<span className="codicon codicon-close" aria-hidden="true" />
</button>
)}
Comment on lines +328 to +337

@coderabbitai coderabbitai Bot May 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Add tests for the new dismiss path.

This introduces user-facing state transitions (show close button for success/error, hide for working, click resets to idle). The provided test context covers status/alert roles, but not this new close interaction. A focused test here would prevent regressions in exactly the thing this PR adds.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/extension/src/webview/components/MermaidPreviewPanel.tsx` around
lines 328 - 337, Add a unit test for MermaidPreviewPanel that verifies the new
dismiss path: render the panel with exportStatus set to a non-"working" state
(e.g., {type: "success"} and {type: "error"}) and assert the close button
(element with class statusCloseButton or aria-label "Close export status
message") is visible for those states but not when exportStatus.type ===
"working"; simulate a click on that close button and assert that the
setExportStatus mock is called with { type: "idle" } (use the existing test
harness/mock for setExportStatus to locate the prop passed into
MermaidPreviewPanel and reuse the alert/role-based selectors already present in
tests).

</div>
)}
{preview.status !== "ok" ? (
Expand Down
Loading