Feature: Determine information about merged cells#323
Open
tgallei wants to merge 1 commit intodhatim:masterfrom
Open
Feature: Determine information about merged cells#323tgallei wants to merge 1 commit intodhatim:masterfrom
tgallei wants to merge 1 commit intodhatim:masterfrom
Conversation
tgallei
changed the title
ochedru
requested changes
Nov 10, 2023
Collaborator
ochedru
left a comment
ochedru
left a comment
There was a problem hiding this comment.
Please make sure this does not introduce any performance regression.
| mergedCellAddress = new CellAddress(mergedCell.getFirstRow(), mergedCell.getFirstColumn()); | ||
| break; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I am afraid this could introduce a huge performance regression if there are many merged cell ranges, Maybe we could organize them in an ordered data structure to speed up this search? For an example, see #236.
|
Is there any update on this? I would love to have a feature to extract the value of merged regions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibility to check whether it is a merged cell and to determine the cell in which the data is stored in a merged cell.
Logic makes it easier to read out the values for merged cells, as the value is only stored in the upper left cell.