Skip to content

fix: highlighted cell synced background #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Birkbjo merged 3 commits into from
Sep 20, 2022
Merged

fix: highlighted cell synced background #181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf78756
fix(cell): fix synced background for highlighted cell
Birkbjo Sep 18, 2022
356ea98
fix: fix highlighted styling
Birkbjo Sep 18, 2022
a20f882
fix: minor cleanup
Birkbjo Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/data-workspace/data-entry-cell/data-entry-cell.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,18 @@
outline: 1px solid #a0adba;
}

.active {
background-color: #fff !important;
}

.highlighted {
outline: 3px solid var(--colors-grey800) !important;
border: none !important;
background: #fff !important;
/* Fix to prevent bottom outline to be clipped by next cell */
z-index: 1;
}


.highlighted.active {
outline-color: var(--theme-focus) !important;
}
Expand All @@ -38,10 +44,11 @@
background: var(--colors-grey300);
}

.invalid:not(.highlighted) {
.invalid:not(.active) {
Copy link
Copy Markdown
Member Author

@Birkbjo Birkbjo Sep 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the highlighted-selector prevented the highlighted-but-unfocused cell to not show the red-background.

background: var(--colors-red200);
outline: 1px solid var(--colors-red600) !important;
outline: 1px solid var(--colors-red600);
}

.invalid:hover {
background: #ffb3bc;
}
Expand Down