fix: [DHIS2-21544] Failed saves leave stale optimistic note in state#4577
Open
Conversation
|
🚀 Deployed on https://deploy-preview-4577.capture.netlify.dhis2.org |
henrikmv
changed the title
simonadomnisoru
approved these changes
May 27, 2026
…4588) Bumps [@dhis2/cli-app-scripts](https://github.com/dhis2/app-platform/tree/HEAD/cli) from 12.11.0 to 12.11.1. - [Release notes](https://github.com/dhis2/app-platform/releases) - [Changelog](https://github.com/dhis2/app-platform/blob/master/CHANGELOG.md) - [Commits](https://github.com/dhis2/app-platform/commits/v12.11.1/cli) --- updated-dependencies: - dependency-name: "@dhis2/cli-app-scripts" dependency-version: 12.11.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Bumps [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) from 7.28.0 to 7.28.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.28.6/eslint/babel-eslint-parser) --- updated-dependencies: - dependency-name: "@babel/eslint-parser" dependency-version: 7.28.6 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [typeface-roboto](https://github.com/KyleAMathews/typefaces) from 0.0.75 to 1.1.13. - [Commits](KyleAMathews/typefaces@v0.0.75...v1.1.13) --- updated-dependencies: - dependency-name: typeface-roboto dependency-version: 1.1.13 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
henrikmv
changed the base branch from
master
to
hv/fix/DHIS2-21580_sequential-errors-are-not-shown-FeedbackBar
…backBar' into hv/fix/DHIS2-21544_failed-saves-leave-stale-optimistic-enrollment-note-in-state
…backBar' into hv/fix/DHIS2-21544_failed-saves-leave-stale-optimistic-enrollment-note-in-state
…failed-saves-leave-stale-optimistic-enrollment-note-in-state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-21544
This PR adds error handling when note saves fail (both enrollment and event notes):
dataEntryandeventsstores) is removed. TheClientNote/FormNotetypes are consolidated into a singleFormNotewithclientId.Key behavioral change on failure: