fix: [DHIS2-21286] fix scrolling to first validation error in tracker/event forms

[karolinelien]

Summary

Fixes two bugs that caused the scroll-to-first-error on save to land in the wrong place. Affects every entry point that uses withSaveHandler (TE registration, enrollment registration, single-event registration, new event in enrollment, edit event) — i.e. both tracker and event programs.

• B1 — D2Form section data elements never scrolled. withGotoInterface was wrapped in forwardRef during the React 18 migration (09ed283). That redirected the parent's ref from GotoFieldInterface to the inner field component, which doesn't expose a goto() method, so instance.goto && instance.goto() in D2Form.validateFormScrollToFirstFailedField silently no-op'd for every section field. Drop the forwardRef wrapper — no consumer reads the forwarded ref. This explains the pre-fix asymmetry where save would scroll to OccurredAt (which uses DataEntryField's own goto()) but not to a section mandatory DE.
• B2 — top-of-form fields (e.g. OccurredAt) landed behind the sticky ScopeSelector bar. Both goto() implementations did scrollIntoView() and then post-corrected with window.scroll(0, scrolledY - 48). The if (scrolledY) guard skipped the correction when scrolledY === 0 (which is exactly what happens when the field is near the top of the document), leaving the field flush with the viewport top — under the sticky ScopeSelector. Replace with scrollIntoView({ block: 'start' }) + scrollMarginTop: '80px' on the wrapper so the browser lands the field 80px below the viewport top regardless of position. 48px covers the SelectorBar height, the remaining 32px is breathing room above the label.

Same fix pattern applied to both call sites (withGotoInterface for in-section data elements and DataEntryField for top-of-form fields).

Test plan

Save is always at the bottom of the form, so the only scroll direction validation needs to drive is up.

• Tracker program stage, OccurredAt empty, click Save → page scrolls UP, OccurredAt label clear of ScopeSelector (tests B2 via DataEntryField)
• Tracker program stage, mandatory section data element empty, click Save → page scrolls UP, that field's label clear of ScopeSelector (tests B1 — broken on master)
• Event program (single-event registration), OccurredAt empty, Save → scrolls UP, label clear of ScopeSelector
• Event program (single-event registration), mandatory section DE empty, Save → scrolls UP, label clear of ScopeSelector (tests B1 on the event-program path)

AI Assisted

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🚀 Deployed on https://deploy-preview-4592.capture.netlify.dhis2.org