chore(ci): remove the temporary jacoco coverage-debug artifacts#24045
Merged
Conversation
The unit-test and integration-h2-test jobs each tarred up the jacoco-aggregate report and uploaded it as a build artifact, behind a 'delete the next 2 steps once we are confident in the coverage setup' comment. Those debug steps were added back in 2022 and have been running ever since. Coverage reporting does not depend on them: codecov is fed directly by the codecov-action step, which reads the jacoco reports itself. The tar/upload only produced a downloadable artifact for manual inspection, which has gone unused. Remove the four steps (two per job).
|
enricocolasante
approved these changes
Jun 1, 2026
ameenhere
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
unit-testandintegration-h2-testjobs each carry two steps prefaced by this comment:They tar up the jacoco-aggregate report and upload it as a 5-day build artifact, purely so someone could download it and eyeball coverage by hand. They were added back in 2022 and have quietly been running on every build ever since — the "temporary" debug crutch became permanent.
Why it's safe to remove
codecov/codecov-actionstep, which reads the jacoco reports directly. These tar/upload steps are not an input to codecov — removing them changes nothing about what codecov receives.This removes the four steps (two per job) and leaves the real coverage path (codecov) and the surefire report steps untouched.
Suggested sanity check before merge
Confirm the codecov dashboard / a recent PR's codecov comment is reporting unit, integration and integration-h2 coverage normally — i.e. we no longer need the manual artifact to trust the setup.
🤖 Generated with Claude Code