fix(deps): align all io.netty:* to 4.2.13.Final via netty-bom#24048
Open
stian-sandvold wants to merge 1 commit into
Open
fix(deps): align all io.netty:* to 4.2.13.Final via netty-bom#24048stian-sandvold wants to merge 1 commit into
stian-sandvold wants to merge 1 commit into
Conversation
Bumps netty-all 4.2.1.Final -> 4.2.13.Final and imports netty-bom so that every io.netty:* module on the classpath resolves to a single, consistent version. Without the BOM the netty-all uber jar mixes with older individual netty modules pulled transitively (e.g. via Artemis and reactor-netty), which causes runtime errors such as AbstractMethodError and NoClassDefFoundError (e.g. io/netty/util/LeakPresenceDetector). This mirrors the alignment already on the 2.41 and 2.42 branches and closes the same gap on 2.43. It also unblocks the reactor-netty-http 1.3.5 upgrade (#23878), which references netty classes only present in newer 4.2.x. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
netty-allfrom4.2.1.Finalto4.2.13.Finaland imports thenetty-bomin dependency management so that everyio.netty:*module on the classpath resolves to one consistent version.Why
We currently pin
netty-all(an uber jar) to one version, but the individual netty modules pulled in transitively — via Artemis, reactor-netty and others — are free to resolve to older versions. That mix on a single classpath leads to runtime failures likeAbstractMethodErrorandNoClassDefFoundError(for example a missingio/netty/util/LeakPresenceDetector), which a green compile does not catch.Importing the
netty-bomforces all netty modules to the same4.2.13.Final, removing the skew.Notes
2.41and2.42branches; this PR closes the identical gap on2.43.2.43that bump currently fails at runtime (NoClassDefFoundError: io/netty/util/LeakPresenceDetector) across the Route and EventHook controllers, because reactor-netty 1.3.x references netty classes that only exist in newer4.2.x. Once this merges, chore(deps): bump io.projectreactor.netty:reactor-netty-http from 1.2.8 to 1.3.5 in /dhis-2 #23878 can rebase and go green.4.2.1 → 4.2.13is a patch-level move within the4.2.xline and is already running on2.42.🤖 Generated with Claude Code