feat: adding a note explaining userroles available#1528
Open
dayures wants to merge 1 commit intodhis2:masterfrom
Open
feat: adding a note explaining userroles available#1528dayures wants to merge 1 commit intodhis2:masterfrom
dayures wants to merge 1 commit intodhis2:masterfrom
Conversation
jason-p-pickering
requested changes
Apr 8, 2025
Contributor
jason-p-pickering
left a comment
There was a problem hiding this comment.
Thanks @dayures . I think we should go a bit further here. The important concept is that users
- Should not be able to give away their own roles due to the security issues you mention
- Only grant other users roles which themselves are a subset of their own role/roles.
While I think we can point out how to enable users giving away their own roles, I think we should provide a much clearer warning about what you generally do not want to do this.
Contributor
Author
|
@jason-p-pickering what do you think about adding this line at the beginning? "By default, to prevent security issues, users are not be able to give away their own roles. Users should only be able to grant other users roles that are a subset of their own." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://community.dhis2.org/t/user-cannot-access-roles-when-creating-another-user/2984/2 from @larshelge