fix: fix download links for both LL and PT#241
Open
edoardo wants to merge 21 commits into
Open
Conversation
|
🚀 Deployed on https://pr-241.event-visualizer.netlify.dhis2.org |
edoardo
force-pushed
the
fix/download-links
branch
from
f9ad6c5 to
269c71a
Compare
edoardo
changed the title
No need for validation logic as currentVis is already validated when enabling the update buttons.
…g legacy visualizations
edoardo
force-pushed
the
fix/download-links
branch
from
a8adf3f to
59b124e
Compare
Contributor
HendrikThePendric
left a comment
HendrikThePendric
left a comment
There was a problem hiding this comment.
I've left a few suggestions. Nothing critical though.
HendrikThePendric
previously approved these changes
Jun 2, 2026
Contributor
HendrikThePendric
left a comment
HendrikThePendric
left a comment
There was a problem hiding this comment.
Small, suggestion but nothing critical
edoardo
force-pushed
the
fix/download-links
branch
from
a702cb9 to
572c62e
Compare
…zeApiSavedVisualization
HendrikThePendric
force-pushed
the
fix/download-links
branch
from
bd63fdd to
d0b95db
Compare
HendrikThePendric
approved these changes
Jun 3, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Download links didn't work properly after the various changes in the analytics requests.
This PR adds fixes to the LL downloads and implements the PT download which was not in place.
For PT the "Advanced" sub-menu is also available, similar to ER/DV.
We need to verify the various downloads, especially the ones for PT, since there are differences in the way we build the analytics request with the Event Reports app.
There is also a fix for
programStatuswhich was ignored when present in the vis obj, but needs to be taken into account and converted into a dimension in filters.The PR also has some fixes to avoid a situation where the
currentVisis updated but the previous analytics data is used when changing layout/outputType and clicking one of the action buttons.This was especially problematic in PT where the PT engine would throw an error due to missing metadata.
Quality checklist
Add N/A to items that are not applicable and check them.
ToDos
Screenshots
Download menu for LL:
Download menu for PT:
