feat: count features without coordinates across all layer types [PR7] [DHIS2-18242]

[BRaimbault]

Parent

• DHIS2-18242

Implements

• DHIS2-237: Count events without coordinates (event layer)
• DHIS2-19850: Count org units without coordinates (thematic, facility, org unit, earth engine layers)

Overview

Seventh PR in the series. Adds a "Count … without coordinates" checkbox to all five layer types. When enabled, the legend shows a Data quality section with the count of features that could not be mapped due to missing coordinates, and those features appear in the data table so they can still be inspected.

Changes

Event layer — count events without coordinates DHIS2-237

A "Count events without coordinates" checkbox is added to the Style tab of the event dialog. When checked, withCoordinatesOnly(false) is passed to the analytics request so all events are returned regardless of coordinate presence. createEventFeatures (geojson.js) now guards against null geometry in buildEventGeometryGetter and splits the result into data (events with coordinates) and dataWithoutCoords (events without). loadData (event.js) returns the split. eventLoader stores dataWithoutCoords on the layer config and sets legend.eventsWithoutCoordinatesCount. Server clustering is disabled when counting is active (encoded in shouldUseServerCluster). The flag is serialised into config.config JSON by favorites.js.

Files: src/util/geojson.js, src/util/event.js, src/loaders/eventLoader.js, src/components/edit/event/EventDialog.jsx, src/util/favorites.js

Org unit / facility / thematic / earth engine layers — count org units without coordinates DHIS2-19850

A "Count org units without coordinates" checkbox is added to the style tabs of the org unit, facility, thematic and earth engine dialogs. When checked, getOrgUnitsWithoutCoordsCount (orgUnits.js) queries the analytics API (using a first available data element as a proxy dimension) to discover which of the requested org unit IDs in the selection have no geometry. The count is stored on legend.orgUnitsWithoutCoordinatesCount; the missing org unit features are stored on config.dataWithoutCoords. For the org unit and thematic layers, fetchOrgUnitDetails enriches each missing feature with its level and parent name before it reaches the data table. For earth engine, countFeaturesWithoutCoordinates is kept as a top-level layer property (consistent with other EE props) rather than embedded in the config JSON.

Files: src/util/orgUnits.js, src/util/requests.js, src/loaders/facilityLoader.js, src/loaders/orgUnitLoader.js, src/loaders/thematicLoader.js, src/loaders/earthEngineLoader.js, src/components/edit/FacilityDialog.jsx, src/components/edit/orgUnit/OrgUnitDialog.jsx, src/components/edit/thematic/ThematicDialog.jsx, src/components/edit/earthEngine/StyleTab.jsx, src/util/favorites.js

Shared plumbing

addGroupCountsToLegend, addLevelCountsToLegend, loadGroupSetData, fetchAndParseGroupSet, fetchAssociatedGeometries are extracted into orgUnits.js and shared by both loaders, reducing cognitive complexity in facilityLoader and orgUnitLoader from ~21 to ~12. useTableData merges dataWithoutCoords into the displayed rows. Legend.jsx shows a Data quality section when either count is set.

Files: src/util/orgUnits.js, src/components/datatable/useTableData.js, src/components/legend/Legend.jsx, src/components/legend/styles/Legend.module.css

Bug fix — null layerEdit in connected component selectors

When a layer dialog closes, LAYER_CANCEL sets layerEdit to null before child components unmount. connect's mapStateToProps runs synchronously in Redux subscription callbacks, causing a crash on any direct layerEdit.x property access. Optional chaining added to all affected connect selectors (StyleByGroupSet, Labels, IsolatedClass, BufferRadius, GeometryCentroid, Classification, SingleColor, NumericLegendStyle, CompletedOnlyCheckbox, RadiusSelect, AggregationTypeSelect, AggregationSelect, BandSelect). Pre-existing bug, surfaced by Cypress testing the org unit dialog close flow.

Files: 13 component files under src/components/

Tests update

• src/util/__tests__/orgUnits.spec.js — getStyledOrgUnits (facility item, org unit layer); addGroupCountsToLegend (reset, increment, no-match, missing dimensions); addLevelCountsToLegend (reset, increment, no-match); getOrgUnitsWithoutCoordsCount (empty ids, no data element, count missing, query error); fetchAndParseGroupSet (success, failure); loadGroupSetData (skip when not needed, skip when already loaded, mutates groupSet, error string on failure)
• src/util/__tests__/geojson.spec.js — buildEventGeometryGetter with null / empty-string geometry; createEventFeatures splits into data + dataWithoutCoords
• src/util/__tests__/favorites.spec.js — countFeaturesWithoutCoordinates serialised to config JSON for thematic and event layers; preserved as top-level property for earth engine layer

Manual testing

Netlify: https://pr-3651.maps.netlify.dhis2.org/ + Instance: https://dev.im.dhis2.org/maps-app-42-3

• DHIS2-237: Event layer — count events without coordinates

  • Test map: ADGFWyG8S6R - main + ADGFWyG8S6R?interpretationId=rGHvPq2TYPn - plugin

    

• DHIS2-19850: Org unit / facility / thematic / EE layers — count org units without coordinates

  • Test maps

    • Thematic: u67g24eoqc1 - main + u67g24eoqc1?interpretationId=djHEdWPlu1m - plugin
    • Facilities: kkwVPb4X38L - main + kkwVPb4X38L?interpretationId=BTpsIwp58OF - plugin
    • OrgUnits: TVxhjqgB4pd - main + TVxhjqgB4pd?interpretationId=ZFPPF72oFAT - plugin
    • Earth Engine: YVyjUIGfdbO - main - YVyjUIGfdbO?interpretationId=PLRl2RCRDaA - plugin
    

Quality checklist

• Jest tests added/updated
• Docs added N/A
• d2-ci dependencies replaced N/A
• Include plugin in testing
• Tester approved (KFMT)

[dhis2-bot]

🚀 Deployed on https://pr-3651.maps.netlify.dhis2.org

[BRaimbault]

Ready for review

[HendrikThePendric]

Changes look good to me. I left a few comments, but nothing critical.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.7% Duplication on New Code

See analysis details on SonarQube Cloud