Fix localized built-in track names in multiplayer room options#116
Open
wangru2025 wants to merge 1 commit into
Open
Fix localized built-in track names in multiplayer room options#116wangru2025 wants to merge 1 commit into
wangru2025 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
In multiplayer room options, the initial built-in track display could be localized, but selecting a built-in track from the track menu stored the raw English display name. That caused the room option announcement to switch from localized text, for example
美国, back toAmerica.This now matches the single race and time trial track selection pattern, where the menu item can display the track name but the selected value is stored by key and formatted later.
Verification
dotnet build top_speed_net/TopSpeed.Tests/TopSpeed.Tests.csproj -c Debug --no-restoredotnet test top_speed_net/TopSpeed.Tests/TopSpeed.Tests.csproj -c Debug --no-build --filter RoomTrackSelection_ShouldTranslateBuiltInTrackKey