fix(app): normalize escaped newlines in release notes#1656
fix(app): normalize escaped newlines in release notes#1656yashranaway wants to merge 1 commit intodifferent-ai:devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@yashranaway is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
src-opn
left a comment
There was a problem hiding this comment.
Code verification issue:
The PR description says Closes #1095, but #1095 asks to make updates active by default with a gentle upgrade flow, including default/migration behavior and escalation paths. This patch only normalizes escaped release-note newlines in apps/app/src/react-app/domains/settings/state/electron-updater-state.ts.
Please remove or change the closing reference before merge, otherwise GitHub will close #1095 even though the requested update-default flow remains unimplemented.
Verification run:
pnpm install --frozen-lockfilepassed.pnpm --filter @openwork/app buildpassed.pnpm --filter @openwork/app typecheckfailed on existing unrelated TypeScript errors outside this patch.
|
@src-opn updated the body to |
Refs #1095 (does not close it; only addresses the rescoped sub-comment about escaped newlines).
Summary
\nand\r\nescape sequences to real newlines in release notes before they reach the Settings updates view.electron-updater, so notes built fromreleaseNotesarrays render with intended line breaks.whitespace-pre-wraprendering path unchanged; this only fixes the source string when the upstream payload is double-escaped.Verification
git diff --checkclean.pnpm --filter @openwork/app typecheckcurrently fails on unrelatedorigin/devTypeScript errors inmessaging-view-state.ts,command-palette.tsx, andsettings-route.tsx; this branch does not touch those files.Notes