Skip to content

fix(app): normalize escaped newlines in release notes#1656

Open
yashranaway wants to merge 1 commit intodifferent-ai:devfrom
yashranaway:fix/release-notes-newlines
Open

fix(app): normalize escaped newlines in release notes#1656
yashranaway wants to merge 1 commit intodifferent-ai:devfrom
yashranaway:fix/release-notes-newlines

Conversation

@yashranaway
Copy link
Copy Markdown
Contributor

@yashranaway yashranaway commented May 5, 2026

Refs #1095 (does not close it; only addresses the rescoped sub-comment about escaped newlines).

Summary

  • Convert literal \n and \r\n escape sequences to real newlines in release notes before they reach the Settings updates view.
  • Apply the same normalization to both the string and array shapes returned by electron-updater, so notes built from releaseNotes arrays render with intended line breaks.
  • Keep the existing whitespace-pre-wrap rendering path unchanged; this only fixes the source string when the upstream payload is double-escaped.

Verification

  • git diff --check clean.
  • pnpm --filter @openwork/app typecheck currently fails on unrelated origin/dev TypeScript errors in messaging-view-state.ts, command-palette.tsx, and settings-route.tsx; this branch does not touch those files.

Notes

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-landing Ready Ready Preview, Comment, Open in v0 May 5, 2026 6:41pm

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 5, 2026

@yashranaway is attempting to deploy a commit to the Different AI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Collaborator

@src-opn src-opn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code verification issue:

The PR description says Closes #1095, but #1095 asks to make updates active by default with a gentle upgrade flow, including default/migration behavior and escalation paths. This patch only normalizes escaped release-note newlines in apps/app/src/react-app/domains/settings/state/electron-updater-state.ts.

Please remove or change the closing reference before merge, otherwise GitHub will close #1095 even though the requested update-default flow remains unimplemented.

Verification run:

  • pnpm install --frozen-lockfile passed.
  • pnpm --filter @openwork/app build passed.
  • pnpm --filter @openwork/app typecheck failed on existing unrelated TypeScript errors outside this patch.

@yashranaway
Copy link
Copy Markdown
Contributor Author

@src-opn updated the body to Refs #1095. The broader "updates active by default" piece from the issue body is up in #1663 (one-line default flip that respects explicit opt-out via the existing readStoredBoolean semantics). The pill-style presentation and required-update path stay open for a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants