fix(server): verify built binary embeds compiled openwork-server#1659
Open
yashranaway wants to merge 1 commit intodifferent-ai:devfrom
Open
fix(server): verify built binary embeds compiled openwork-server#1659yashranaway wants to merge 1 commit intodifferent-ai:devfrom
yashranaway wants to merge 1 commit intodifferent-ai:devfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@yashranaway is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@src-opn Can you please take a look? |
Collaborator
|
@yashranaway plz dont tag, we review things regularly. tagging should only be used for crucial important stuff |
Contributor
Author
|
my bad, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1229
Summary
openwork-serverbinary with--versionimmediately afterbun build --compileand confirm the output matches the package version..deband propagate to AUR.Verification
pnpm --filter openwork-server typecheckclean.bun ./script/build.ts --outdir /tmp/owork-server-test --filename openwork-serverproduces a working binary;/tmp/owork-server-test/openwork-server --versionprints the package version.bunand re-running the verification logic exits non-zero withexpected --version: 0.13.3/actual stdout: 1.3.6, matching the symptom in the issue.Notes
build:binshorthand inapps/server/package.json(developer convenience path) and the equivalent server-v2 build script. The release path that feeds TauriexternalBinand the.debasset goes throughapps/desktop/scripts/prepare-sidecar.mjs->apps/server/script/build.ts, which is what this PR hardens.