fix: prevent Enter key during IME composition from triggering execution#490
Closed
liuxiaopai-ai wants to merge 1 commit intodifferent-ai:devfrom
Closed
fix: prevent Enter key during IME composition from triggering execution#490liuxiaopai-ai wants to merge 1 commit intodifferent-ai:devfrom
liuxiaopai-ai wants to merge 1 commit intodifferent-ai:devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #442
When using an IME (e.g. Japanese, Chinese, Korean input methods), pressing Enter to confirm character conversion was incorrectly triggering form submissions, message sends, and other actions. This happened because the keydown handlers did not check the
event.isComposingproperty or the legacyevent.keyCode === 229indicator.Changes
Added
if (event.isComposing || event.keyCode === 229) return;guard to all Enter key handlers across 10 files:composer.tsx— Main chat input (message send, mention select, slash command select). Consolidated the existing partial guard into a single early-return at the top of the keydown handler.model-picker-modal.tsx— Model selection on Enterquestion-modal.tsx— Option selection and custom input submission (2 handlers)rename-session-modal.tsx— Session rename on Enterrename-workspace-modal.tsx— Workspace rename on Enterdashboard.tsx— Keyboard-accessible workspace/session list items (3 handlers)session.tsx— Keyboard-accessible workspace/session list items (3 handlers)proto-v1-ux.tsx— Expandable section toggleskills.tsx— Skill card activationonboarding.tsx— Directory path input submissionWhy both checks?
event.isComposing— The standard W3C property indicating active IME compositionevent.keyCode === 229— Legacy fallback for older browsers and some Android IMEs that don't setisComposingcorrectlyTesting