fix: prevent Enter key during IME composition from triggering actions#492
Merged
benjaminshafii merged 1 commit intodifferent-ai:devfrom Feb 7, 2026
Merged
Conversation
When using an IME (e.g. Chinese, Japanese, Korean input methods), pressing Enter to confirm character conversion was incorrectly triggering form submissions, message sends, and other actions. Changes across 10 files: - composer.tsx: triple-check IME state (event.isComposing + manual compositionstart/end flag + keyCode === 229) with addEventListener binding to work around SolidJS event delegation limitations - model-picker-modal.tsx: guard Enter for model selection - question-modal.tsx: guard Enter for option/custom input (2 handlers) - rename-session-modal.tsx: guard Enter for session rename - rename-workspace-modal.tsx: guard Enter for workspace rename - dashboard.tsx: guard Enter for workspace/session list items (3 handlers) - session.tsx: guard Enter for workspace/session list items (3 handlers) - proto-v1-ux.tsx: guard Enter for expandable section toggle - skills.tsx: guard Enter for skill card activation - onboarding.tsx: guard Enter for directory path input
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an IME (e.g. Chinese, Japanese, Korean input methods), pressing Enter to confirm character conversion was incorrectly triggering form submissions, message sends, and other actions.
Changes across 10 files: