Make cleanups#23
Merged
differrari merged 6 commits intodifferrari:consolefrom Aug 10, 2025
Merged
Conversation
Instead of using `gcc` to compile both C and C++, use `gcc` for C and `g++` for C++. This allows to split flags more cleanly. Re-organize flag variables a bit, adding `CPPFLAGS` for C preprocessor flags, `CFLAGS` for C compiler flags and `CXXFLAGS` for C++ compiler flags.
This makes it easier to see the build output/warnings. Full build output can be enabled with `make V=1`.
Include common.mk from the other Makefiles instead of exporting variables from the top-level Makefile so they get expanded correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various cleanups and improvements to Make build system.
Most notably extracting common variables into
common.mkfile and including that in the other Makefiles and enabling "silent" builds (by default) to make it easier to grok the build system output. Silent build can be disabled by passing V=1 argument to Make likemake V=1.Feel free to ignore or cherry-pick.
It's based on my previous PR branch so includes that commit, hopefully it can merge cleanly. I can probably fix it if it gives any grief.