Support release build#29
Closed
codebrainz wants to merge 1 commit intodifferrari:consolefrom
Closed
Conversation
Owner
|
Have you tested this? I'd be shoked if optimizations work |
Contributor
Author
|
I tested it builds ok, but as you suspected on-stream, it doesn't actually boot. The idea was just to make it easier to test optimized builds for finding/fixing compiler warnings/issues and for helping to fix the underlying issues that cause it not to boot. No biggie though, it's simple enough to manually edit the make file to change the compiler flags, and it could easily be added later once the volatile-related issues preventing booting are fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual commit is here: fc8cbac
Safe to merge but when
make RELEASE=1is used, it doesn't work due missing volatile on variables and whatever else.Defaults to existing behaviour.
TODO: base it on whatever branch is the "dev" branch. I'll fix it if the change is desired and base branch is recommended.