[STRING] Don't hardcode the string length, instead use a #define.#37
Merged
differrari merged 1 commit intodifferrari:mainfrom Aug 16, 2025
Merged
Conversation
differrari
approved these changes
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hard coding the string length I put a
#definein the header so that it is much easier to change the maximum string length as there quite a couple uses of it throughoutshared/std/string.c. This also makes it easier to understand that what the number 256 represents (the max string length). In some places 255 is used so I just didMAX_STRING_LEN - 1.