Conversation
Collaborator
johnykei
commented
Jan 22, 2025
johnykei
commented
- 依存パッケージのアップデート
upgrade dependencies
upgrade tailwindcss
upgrade dependencies
tsmd
reviewed
Jan 22, 2025
| | ------------------ | ---------------- | | ||
| | 2.1.2 | 0.2.3 | | ||
| | 2.1.1 | 0.2.3 | | ||
| | 2.1.0 | 0.2.3 | |
Collaborator
There was a problem hiding this comment.
Figma 2.0.4に対応するパッケージのバージョンも0.2.3にしてしまって良さそうです。
トークン自体は変わっていないので互換性は保たれているはずなので〜。
Collaborator
Author
There was a problem hiding this comment.
@tsmd
ここどう書こうか悩んでたんですが、design-tokens も 2.0.4 は前バージョンとしているのでそれに合わせましたー。
今後もバージョンが増えていくので、ここの書き方の整理はまた考えましょう！なので今回はこのままでリリースでいけると幸いですー。
Collaborator
There was a problem hiding this comment.
このファイルの差分って必要な感じでしょうか？
Biomeの設定ファイルを見るとexamplesディレクトリは除外されているようでしたが〜 👀
Collaborator
Author
There was a problem hiding this comment.
@tsmd
これ dist にあるビルド結果をそのまま examples にコピーしてて、最新のパッケージを使った分のビルド結果が差分ある感じなんですよね。差分見た感じフォーマットレベルくらいでしたが、今後も差分が出る可能性あるので入れてしまうでいいかと思ってます！
Collaborator
There was a problem hiding this comment.
ビルド結果そのままならば問題ないですね。ありがとうございます！
tsmd
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.