Skip to content

Fix errant packages found via test dep. graph#68

Merged
anitgandhi merged 3 commits into
digitalocean:masterfrom
michaeldye:fix-traversal-of-test-deps-on-revgraph
Feb 13, 2026
Merged

Fix errant packages found via test dep. graph#68
anitgandhi merged 3 commits into
digitalocean:masterfrom
michaeldye:fix-traversal-of-test-deps-on-revgraph

Conversation

@michaeldye

Copy link
Copy Markdown
Contributor

Track test dependencies separately from production dependencies. Direct test dependents are still marked (their tests need re-running), but we don't traverse the dep graph further to their production dependents since those packages have not necessarily changed.

Comment thread packager.go Outdated
@michaeldye michaeldye requested a review from anitgandhi February 3, 2026 18:34
@anitgandhi

Copy link
Copy Markdown
Contributor

since this is a behavior change, it would be good to do this behind a new CLI flag like -test-transitive or something like that

@michaeldye michaeldye force-pushed the fix-traversal-of-test-deps-on-revgraph branch 2 times, most recently from 230db48 to edda79d Compare February 12, 2026 05:43

@anitgandhi anitgandhi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@michaeldye michaeldye force-pushed the fix-traversal-of-test-deps-on-revgraph branch from edda79d to 1e7ae5f Compare February 12, 2026 21:21
Track test dependencies separately from production dependencies.
Direct test dependents are still marked (their tests need re-running),
but we don't traverse the dep graph further to their production
dependents since those packages have not necessarily changed.
This option defaults to true and preserves legacy behavior. If
-test-transitiive=false, gta will retain test as dependencies that need
to be revisited b/c of a change, but not include them in reverse-graph
traversal. This substantially cuts down on the quantity of tested
packages.
@michaeldye michaeldye force-pushed the fix-traversal-of-test-deps-on-revgraph branch from 1e7ae5f to 429a75a Compare February 12, 2026 21:28
@anitgandhi anitgandhi merged commit ead3a06 into digitalocean:master Feb 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants