GRPC for Google write operations + compression#4
GRPC for Google write operations + compression#4tdutreui-solocal wants to merge 6 commits intodigivizer:google-grpc-compatiblefrom
Conversation
lib/gcr.rb
Outdated
| # Whether cassettes should be compressed to zz | ||
| # | ||
| # Returns a boolean | ||
| def compress |
There was a problem hiding this comment.
| def compress | |
| def compress? |
… API calls with different responses
danielmbarlow
left a comment
There was a problem hiding this comment.
Thanks TD. Just had a smal comment to make about a minor detail
lib/gcr/cassette.rb
Outdated
| raise GCR::NoRecording.new(["Unrecorded request :", | ||
| "called #{calls_count} #{(calls_count > 1) ? "times" : "time"}, (recorded #{interactions.size})", | ||
| req.class_name, | ||
| req.body] | ||
| .join("\n")) |
There was a problem hiding this comment.
This is a little difficult to read maybe we could extract some variables and improve the whitespace
|
@asux Hi ! I propose you these improvements that we have been testing for some months now, without major issues. |
|
Hi @tdutreui-solocal. I'm bit loose context about this GCR, since not use it in recent project. Generally, your code makes sense to me. |
GCR_RECORDenvvar so that you can override an existing cassette