Update test output for compatibility with pluralisation changes in GAP#808
Closed
wilfwilson wants to merge 7 commits into
Closed
Update test output for compatibility with pluralisation changes in GAP#808wilfwilson wants to merge 7 commits into
wilfwilson wants to merge 7 commits into
Conversation
wilfwilson
added
minor
wilfwilson
force-pushed
the
update-pluralization
branch
from
6f54ffe to
dfe0e22
Compare
Move digraphs-specific modifications out of the EAPS source code, so that EAPS can easily be updated by just replacing files and not having to look for custom edits.
* Change to GAP stable-4.14 in CI * Add HasPseudoSimilarVertices no docs * Fixed syntax * fixed syntax * Add HasPSVs * Is2EdgeTransitive overhaul using Orbit-Stabiliser Theorem * Added support for digraphs with loops * Linting * More linting * Edited Documentation * Edited Documentation again * Once more rewritten Is2EdgeTransitive, this time to avoid looping through all triples of vertices, and instead checks center vertices of 2-edges * lint * Added more comments to prop.gi * Fix trailing whitespace * Added IsTwoEdgeTransitive as synonym for Is2EdgeTransitive * lint * Removed spurious files and added what happens when the argument of Is2EdgeTransitive has multiple edges to doc * fixed typo in doc
* Avoid 1-argument `First`/`Last` – instead use `list[1]`/`list[Length(list)]` * Include compiled.h in GAP 4.10, since gap_all.h doesn't exist yet
wilfwilson
force-pushed
the
update-pluralization
branch
from
dfe0e22 to
3073e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Digraphs so that it will be compatible with a future version of GAP in which the PR gap-system/gap#4343 (concerning pluralisation) is merged.
Amongst other things, gap-system/gap#4343 changes the output of "no method found" errors so that it now (grammatically correctly) says "1 argument" instead of "1 arguments".
Unfortunately, until gap-system/gap#4343 is actually merged into the GAP master branch, it will cause the CI here to fail on any GAP
masterjobs. It's a bit of a chicken and egg problem and I'm not sure how to resolve it.The fix is relatively small although a little tedious; I think the required changes to the Semigroups package will be much worse...