Update regular expression filters with proper error handling#133
Open
andrlime wants to merge 1 commit intodilanx:mainfrom
Open
Update regular expression filters with proper error handling#133andrlime wants to merge 1 commit intodilanx:mainfrom
andrlime wants to merge 1 commit intodilanx:mainfrom
Conversation
andrlime
force-pushed
the
regular-expression-bug-fix
branch
from
2478921 to
7f8a689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Regular Expression Search Filters
Summary
This pull request addresses ticket #ODXEx8Y. The TLDR is that searching and including regular expression characters – e.g. [, (, { – but not closing the brackets, leads to a full page crash because
Search.tstries to instantiate an invalid regular expression.A new function was added to wrap instantiation in a try catch, and invalid regular expressions now propagate an error message to the user-facing frontend.
A side effect is that some
forEachcalls were replaced withfor (const ... of ...)in order to support short circuit value returning.Testing
The fixes were tested locally. The crash has been fixed.