Open
Conversation
Author
|
Hi @dillingham, I added another commit to this pull request - to allow for user to specify "ASC" or "DESC" sort direction. So now the user could specify the AttachMany field like so:
Please let me know if you have any other questions, or if there's anything else I could do. Thanks again. |
|
#24 (comment) posted by @davejamesmiller shows how "sorting" can quite easily be done without the need for this Pull Request or changing any code in this repository. This Pull Request can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Brian,
I'm pretty new when it comes to creating pull requests, and I don't thoroughly understand your (and Nova's) codebase, but I hope this Pull Request will at least give you a good idea of a way to implement an "orderBy" option with which the user can specify the columns by which to order the listing by.
Just as an example as to how this would look in a Resource, which uses your AttachMany field:
Please let me know if there's anything else I can do from my end.
Thank you for your very useful & helpful tool!