Upgrade minimum Java version from 17 to 21#10
Open
dillonvargo wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Dillon Vargo <dillonvargo@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This PR upgrades the minimum required Java version from 17 to 21 across the codebase:
validateJavaVersion()to properly check for Java 21 minimum. The previous implementation only rejected Java 7 and earlier using an outdated regex pattern. The new implementation parses the major version from both old-style (1.x.y) and new-style (21.0.1) version strings.*:prefix for the debug address.The Dockerfile was verified and already correctly uses Java 21.
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-
Checklist: I completed these to help reviewers :)
mvn clean packageright before creating this pull request and added all formatting changes to my commit.Items for reviewer attention
validateJavaVersion()method change could benefit from test coverage for the new parsing logicRequested by: Dillon Vargo (@dillonvargo)
Link to Devin run: https://app.devin.ai/sessions/720a2eb76f6c41c1b2e02d66b76475e5