Add test coverage improvement plan document#11
Open
dillonvargo wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Dillon Vargo <dillonvargo@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Added
TEST_COVERAGE_IMPROVEMENT_PLAN.md— a documentation-only file that outlines a structured, phased approach to improving test coverage across openmrs-core. The document covers:ConditionService,DiagnosisService,SerializationService, and 9 Hibernate DAO classes)BaseVoidHandlermasks coverage ofvoid*/retire*methodsNo functional code changes — this is documentation only.
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-5151 (partially — the AOP coverage gap is one of several items addressed in this plan)
Checklist: I completed these to help reviewers :)
mvn clean packageright before creating this pull request and added all formatting changes to my commit.Items for Reviewer Attention
ConditionService,DiagnosisService, andSerializationServicehave no test files, and that 9 DAO classes are untested. These were determined by directory listing — please confirm no tests exist under alternate names or locations.@InjectMocksonPersonServiceImplto bypass AOP should be validated — the void logic may live entirely in the AOP handler rather than the method body, which would change the testing strategy.pom.xmland source file line numbers that will become stale over time. Consider whether these references add enough value to justify maintenance.Link to Devin run: https://app.devin.ai/sessions/daeb89e4ebe64b078ac5575befeb4e41
Requested by: Dillon Vargo