Add comprehensive testing improvement plan#12
Open
dillonvargo wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Dillon Vargo <dillonvargo@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Added a markdown planning document (
testing-improvement-plan.md) at the repository root that outlines a prioritized strategy for improving test coverage across OpenMRS Core. The document covers four areas:OpenmrsTestsTest.javato detect test methods that lackassert*/verify*calls (addresses the existing TODO at lines 39-42).@Disabledtests across 21 files, categorized into three tiers (ticket-referenced, no-ticket, and intentionally-disabled utilities), with action items for each.BaseVoidHandler/RequiredDataAdviceAOP pattern that causes low branch coverage invoid*service methods (TRUNK-5151), and proposes testing strategies.reportandcheckgoals to the existing JaCoCo config to enforce coverage thresholds.No code changes — this is a planning document only.
Issue I worked on
This plan references multiple existing tickets:
Checklist: I completed these to help reviewers :)
mvn clean packageright before creating this pull request and added all formatting changes to my commit.Items for reviewer attention
docs/directory.@Disabledannotations across 21 files was gathered via grep; confirm nothing was missed or miscounted.Link to Devin run: https://app.devin.ai/sessions/f85e30cdef124cceb11ddef199f6d780
Requested by: Dillon Vargo (dillon.vargo@windsurf.com)