Improve Docker configuration: standardize JDK, add JAVA_VERSION arg, update Tomcat#14
Open
dillonvargo wants to merge 1 commit into
Open
Improve Docker configuration: standardize JDK, add JAVA_VERSION arg, update Tomcat#14dillonvargo wants to merge 1 commit into
dillonvargo wants to merge 1 commit into
Conversation
…update Tomcat - Standardize JDK references: update bamboo.yml to use eclipse-temurin-21 instead of amazoncorretto-21 - Add JAVA_VERSION build arg to Dockerfile for easier Java version switching (17, 21, 24) - Update Tomcat from 11.0.11 to 11.0.18 with updated SHA512 checksum Co-Authored-By: Dillon Vargo <dillonvargo@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Three improvements to the Docker and CI configuration:
Made Java version configurable via a single
JAVA_VERSIONbuild arg in the Dockerfile.DEV_JDKandRUNTIME_JDKare now derived from it, so switching Java versions (e.g.,--build-arg JAVA_VERSION=17) requires changing only one value instead of two.Standardized JDK distribution references across Dockerfile and
bamboo-specs/bamboo.yml. The Dockerfile already used Eclipse Temurin; the CI pipeline (bamboo.yml) usedamazoncorretto-21for image tagging in the Deploy and Release jobs. Both now consistently useeclipse-temurin-21.Updated Tomcat from 11.0.11 → 11.0.18 (latest stable release) with updated SHA512 checksum.
Items for reviewer attention
JAVA_VERSIONis defined in global scope and used to deriveDEV_JDK/RUNTIME_JDKwhich feed intoFROMinstructions. This should work per Docker spec, but is worth verifying with a build.JDK_IMAGEvariable is used as a suffix for published Docker image tags (e.g.,openmrs/openmrs-core:nightly-eclipse-temurin-21). Previously these tags used-amazoncorretto-21. Downstream consumers pulling by the old tag suffix will need to update.downloads.apache.org; please independently verify.Issue I worked on
No JIRA issue — configuration improvement for maintainability.
Checklist: I completed these to help reviewers :)
mvn clean packageright before creating this pull request and added all formatting changes to my commit.Link to Devin run: https://app.devin.ai/sessions/4a84210e3aad4dbd8329f36959782d2c
Requested by: @dillonvargo