Upgrade Java 17/8 references to Java 21#18
Open
dillonvargo wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Dillon Vargo <dillonvargo@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Updated all outdated Java version references to reflect that Java 21 is now the minimum required version:
java17Maven profile. An identicaljava21profile already exists with the same mockito-core and byte-buddy dependency overrides, making thejava17profile redundant.validateJavaVersion()to check for Java 21+ instead of Java 8+. The old regex (1\\.[0-7]\\.(.*)) only caught legacy version strings (Java 7 and below) and wouldn't have rejected Java 8–20 under modern version formats. The new implementation parses the major version number from both legacy1.x.yand modernX.Y.Zversion strings.Things for reviewers to verify
validateJavaVersion()would reject early-access JDK builds (e.g.,"21-ea") becauseInteger.parseInt("21-ea")falls into theNumberFormatExceptioncatch, settingmajorVersion = 0. Determine if this is acceptable or if the hyphen should be stripped before parsing.validateJavaVersion()logic. Consider whether the existing test suite covers this or if new tests are needed.Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-
Checklist: I completed these to help reviewers :)
mvn clean packageright before creating this pull request and added all formatting changes to my commit.Link to Devin run: https://app.devin.ai/sessions/c1f60c01567741799798bdd917fa4d2a
Requested by: @dillonvargo