Skip to content

Remove Java 17 Maven profile (upgrade to Java 21)#20

Open
dillonvargo wants to merge 1 commit into
masterfrom
devin/1771812914-upgrade-java17-to-java21
Open

Remove Java 17 Maven profile (upgrade to Java 21)#20
dillonvargo wants to merge 1 commit into
masterfrom
devin/1771812914-upgrade-java17-to-java21

Conversation

@dillonvargo

Copy link
Copy Markdown
Owner

Description of what I changed

Removed the java17 Maven profile from pom.xml. This profile was redundant because:

  • The project's javaCompilerVersion is already set to 21
  • The java17 profile had identical dependency versions (mockito-core 5.19.0, byte-buddy 1.17.7, byte-buddy-agent 1.17.7) to the existing java21 profile
  • The associated comment about a Java 17 mockito-core bug was also removed along with the profile

The remaining java21 and java24 profiles are unchanged.

Issue I worked on

Cleanup of stale Java 17 references now that the project targets Java 21.

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.
  • I have added tests to cover my changes. (No code logic changed; profile removal only.)
  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

Key items for reviewer

  • Confirm Java 17 builds are no longer needed. If anyone still builds with JDK 17, they will lose the mockito/byte-buddy version pinning that this profile provided.
  • The java21 and java24 profiles remain intact and were not modified.

Requested by: @dillonvargo
Link to Devin run: https://app.devin.ai/sessions/4be04317a45c49cbaf1955973d787dfb

@devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant