Update minimum Java version references from Java 8 to Java 21#23
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Update minimum Java version references from Java 8 to Java 21#23devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Update validateJavaVersion() to correctly detect JVM versions below 21 using both legacy (1.x) and modern (x.y.z) version schemes - Update README.md to state Java 21 as minimum required JDK version Co-Authored-By: unknown <>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Updated the two remaining references to Java 8 as the minimum supported version to reflect Java 21:
OpenmrsUtil.validateJavaVersion()— Replaced the old regex check (1\\.[0-7]\\.(.*)) with version-parsing logic that handles both the legacy1.x.yscheme (pre-Java 9) and the modernx.y.zscheme (Java 9+). The method now throws anAPIExceptionif the detected major version is below 21.README.md— Updated the prerequisite text from "minimum version 8" to "minimum version 21".Things for reviewers to look at closely
1.x.y,x.y.z,x-ea, and barexformats. Verify this covers all realisticjava.versionvalues your environments produce.NumberFormatExceptionrisk: Unlike the old regex (which silently passed on unrecognized formats),Integer.parseIntwill throw ifjava.versionis unexpectedly malformed. This is a minor behavior change.JavaVersionTestonly callsvalidateJavaVersion()on the running JVM (Java 21 in CI), so it will still pass — but it doesn't exercise the rejection path or edge-case version strings.Issue I worked on
No JIRA issue — this is a documentation/config alignment change. The project's
pom.xmlalready targets Java 21 (<javaCompilerVersion>21</javaCompilerVersion>) and CI usesamazoncorretto-21.Checklist: I completed these to help reviewers :)
mvn clean packageright before creating this pull request and added all formatting changes to my commit.Link to Devin run: https://app.devin.ai/sessions/9bfcbad15326404793a4355072703927
Requested by: @dillonvargo