Upgrade Java 17 Maven profile to Java 21 and remove duplicate profile#25
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Upgrade Java 17 Maven profile to Java 21 and remove duplicate profile#25devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…profile Co-Authored-By: unknown <>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Removed the
java17Maven profile frompom.xml. This profile overrodemockito-core,byte-buddy, andbyte-buddy-agentdependency versions when JDK 17 was detected. Since an identicaljava21profile already exists with the exact same dependency versions (mockito-core 5.19.0, byte-buddy 1.17.7, byte-buddy-agent 1.17.7), thejava17profile was redundant and has been removed to avoid duplication.After this change, the JDK-specific profiles are
java21andjava24.Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-
Things for reviewers to verify
java21profile, it may be worth updating or generalizing this comment.Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
N/A — build configuration change only, no testable code.
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
Link to Devin run: https://app.devin.ai/sessions/f4e59a576bcd4c8f9ec24313fc6eeec3
Requested by: @dillonvargo