Update test module to Java 21 and migrate to Jakarta Servlet API#8
Open
dillonvargo wants to merge 1 commit into
Open
Update test module to Java 21 and migrate to Jakarta Servlet API#8dillonvargo wants to merge 1 commit into
dillonvargo wants to merge 1 commit into
Conversation
- Update javaCompilerVersion from 1.8 to 21 in test-module/pom.xml - Replace javax.servlet-api:4.0.1 with jakarta.servlet-api:6.1.0 in test-module/pom.xml - Replace javax.servlet-api with jakarta.servlet-api in test-module/omod/pom.xml This aligns the test module with the main project's Java 21 configuration and Jakarta EE migration. Co-Authored-By: Dillon Vargo <dillonvargo@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Updated the test module to use Java 21 and migrated from javax.servlet to Jakarta Servlet API to align with the main project's configuration:
javaCompilerVersionproperty from1.8to21intest-module/pom.xmljavax.servlet-api:4.0.1dependency withjakarta.servlet-api:6.1.0intest-module/pom.xmltest-module/omod/pom.xmlfromjavax.servlet-apitojakarta.servlet-apiThe main project already uses Java 21, Spring Framework 6.x, Hibernate 6.x, and Jakarta Servlet 6.1.0. This change ensures the test module is consistent with the rest of the codebase and eliminates the use of Java 1.8 which reached end-of-life in 2022.
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
Reviewer Notes
Key areas to verify:
javax.servletimports that would need updatingRequested by: Dillon Vargo (@dillonvargo)
Link to Devin run: https://app.devin.ai/sessions/bd1bb8bc23f148d4b7d1dd3a1ebba66e