Upgrade Java version requirements from Java 8 to Java 17/21#9
Open
dillonvargo wants to merge 1 commit into
Open
Upgrade Java version requirements from Java 8 to Java 17/21#9dillonvargo wants to merge 1 commit into
dillonvargo wants to merge 1 commit into
Conversation
- Update test-module/pom.xml: Change javaCompilerVersion from 1.8 to 21 - Update OpenmrsUtil.validateJavaVersion(): Enforce Java 17 as minimum version - Update README.md: Change Java requirement from version 8 to 17 or 21 Co-Authored-By: Dillon Vargo <dillonvargo@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This PR addresses Java version inconsistencies in the codebase by upgrading from Java 8 to Java 17/21:
javaCompilerVersionfrom1.8to21to match the root pom.xmlgetMajorJavaVersion()helper method that handles both old-style version strings (1.8.0_xxx) and new-style (17.0.x, 21.0.x)Issue I worked on
No JIRA ticket - this addresses Java version inconsistencies where the main project targets Java 21 but several components still referenced Java 8.
Checklist: I completed these to help reviewers :)
mvn clean packageright before creating this pull request and added all formatting changes to my commit.Items for reviewer attention
getMajorJavaVersion()for edge cases - it handles old format (1.x), new format (17.0.x), and versions without dots (17-ea)JavaVersionTestpasses but doesn't test the new helper method or edge cases. Consider whether additional test coverage is needed.This PR was created with assistance from Devin on behalf of @dillonvargo