Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 90 additions & 53 deletions frontend/src/components/LoopControls.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { useState } from 'react';
import type { LoopStatus } from '../types/task';
import type { Task } from '../types/task';
import { formatTokens } from '../lib/formatTokens';
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”΄ bugs: Import formatTokens from '../lib/formatTokens' references a module that does not exist. No formatTokens.ts file exists in frontend/src/lib/. This will cause a build/runtime error when the component is loaded, even if totalTokenUsage is 0 (the import itself fails). [fixable]


interface LoopControlsProps {
loopStatus: LoopStatus;
goals: Task[];
totalTokenUsage: number;
onStart: (goalId: string, specMode?: boolean) => void;
onPause: () => void;
onResume: () => void;
Expand All @@ -13,42 +15,38 @@ interface LoopControlsProps {
onRejectSpec: () => void;
}

const STATE_LABELS: Record<LoopStatus['state'], string> = {
idle: 'Idle',
running: 'Running',
paused: 'Paused',
};

export function LoopControls({
loopStatus,
goals,
totalTokenUsage,
onStart,
onPause,
onResume,
onStop,
onApproveSpec,
onRejectSpec,
}: LoopControlsProps) {
const [pickerOpen, setPickerOpen] = useState(false);
const [selectedGoalId, setSelectedGoalId] = useState('');
const [specMode, setSpecMode] = useState(false);

const { state, progress, awaitingApproval } = loopStatus;

return (
<div className="loop-controls">
<div className="loop-controls-header">
<span className={`loop-controls-pill loop-controls-pill--${state}`}>
{STATE_LABELS[state]}
</span>
{progress && (
<span className="loop-controls-progress">
{progress.done}/{progress.total}
</span>
)}
</div>
// ── Idle: compact trigger / expanded picker ──
if (state === 'idle') {
if (!pickerOpen) {
return (
<div className="loop-controls">
<button className="loop-controls-start-trigger" onClick={() => setPickerOpen(true)}>
{'\u25B8'} Start a workflow...
</button>
</div>
);
}

{state === 'idle' && (
<div className="loop-controls-start">
return (
<div className="loop-controls">
<div className="loop-controls-start-expanded">
<select
className="loop-controls-select"
value={selectedGoalId}
Expand All @@ -70,61 +68,100 @@ export function LoopControls({
/>
Spec mode
</label>
<div className="loop-controls-spacer" />
<button className="loop-controls-btn" onClick={() => setPickerOpen(false)}>
Cancel
</button>
<button
className="loop-controls-btn loop-controls-btn--start"
disabled={!selectedGoalId}
onClick={() => onStart(selectedGoalId, specMode || undefined)}
onClick={() => {
onStart(selectedGoalId, specMode || undefined);
setPickerOpen(false);
}}
>
Start
</button>
</div>
</div>
)}
</div>
);
}

{state === 'running' && !awaitingApproval && (
<div className="loop-controls-actions">
<button className="loop-controls-btn" onClick={onPause}>
Pause
</button>
<button className="loop-controls-btn loop-controls-btn--danger" onClick={onStop}>
Stop
</button>
</div>
)}
// ── Running / Paused / Review: inline bar ──
const isReview = awaitingApproval;
const pillClass = isReview
? 'loop-controls-pill--review'
: state === 'paused'
? 'loop-controls-pill--paused'
: 'loop-controls-pill--running';
const pillLabel = isReview
? '\u26A0 Needs Review'
: state === 'paused'
? 'Paused'
: '\u25CF Running';

{state === 'paused' && !awaitingApproval && (
<div className="loop-controls-actions">
<button className="loop-controls-btn loop-controls-btn--start" onClick={onResume}>
Resume
</button>
<button className="loop-controls-btn loop-controls-btn--danger" onClick={onStop}>
Stop
</button>
return (
<div className="loop-controls">
<div className="loop-controls-inline-bar">
<div className="loop-controls-inline-bar-top">
<span className={`loop-controls-pill ${pillClass}`}>{pillLabel}</span>
<div className="loop-controls-spacer" />
<div className="loop-controls-actions">
{state === 'running' && !awaitingApproval && (
<button className="loop-controls-btn" onClick={onPause} title="Pause">
{'\u23F8'}
</button>
)}
{state === 'paused' && !awaitingApproval && (
<button
className="loop-controls-btn loop-controls-btn--start"
onClick={onResume}
title="Resume"
>
{'\u25B6'}
</button>
)}
<button
className="loop-controls-btn loop-controls-btn--danger"
onClick={onStop}
title="Stop"
>
{'\u25A0'}
</button>
</div>
</div>
)}
{progress && progress.total > 0 && (
<div className="loop-controls-inline-bar-bottom">
<div className="loop-controls-bar">
<div
className="loop-controls-bar-fill"
style={{ width: `${(progress.done / progress.total) * 100}%` }}
/>
</div>
<span className="loop-controls-progress">
{progress.done}/{progress.total}
</span>
{totalTokenUsage > 0 && (
<span className="loop-controls-token-count">{formatTokens(totalTokenUsage)}</span>
)}
</div>
)}
</div>

{awaitingApproval && (
<div className="loop-controls-approval">
<div className="loop-controls-approval-card">
<p className="loop-controls-approval-msg">Task breakdown ready for review</p>
<div className="loop-controls-actions">
<button className="loop-controls-btn loop-controls-btn--start" onClick={onApproveSpec}>
Approve
{'\u2713'} Approve
</button>
<button className="loop-controls-btn loop-controls-btn--danger" onClick={onRejectSpec}>
Reject
{'\u2717'} Reject
</button>
</div>
</div>
)}

{progress && progress.total > 0 && (
<div className="loop-controls-bar">
<div
className="loop-controls-bar-fill"
style={{ width: `${(progress.done / progress.total) * 100}%` }}
/>
</div>
)}
</div>
);
}
15 changes: 2 additions & 13 deletions frontend/src/components/SessionOverview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
type SessionActivityState,
} from '../hooks/useSessionOverview';
import { selectionChanged } from '../lib/haptics';
import { formatRelativeTime } from '../lib/formatTime';

// ─── State visuals ──────────────────────────────────────────────────────────

Expand All @@ -29,8 +30,7 @@ function SessionActivityCard({
}) {
const config = STATE_CONFIG[activity.state];
// Elapsed updates on each SSE event, not on a timer β€” acceptable staleness
const elapsed = Date.now() - activity.lastEventAt;
const timeLabel = formatElapsed(elapsed);
const timeLabel = formatRelativeTime(activity.lastEventAt);

let metaText = config.label;
if (activity.waitReason === 'permission') metaText = 'permission';
Expand Down Expand Up @@ -121,14 +121,3 @@ export function SessionOverview() {
</div>
);
}

// ─── Helpers ────────────────────────────────────────────────────────────────

function formatElapsed(ms: number): string {
const seconds = Math.floor(ms / 1000);
if (seconds < 60) return 'just now';
const minutes = Math.floor(seconds / 60);
if (minutes < 60) return `${minutes}min ago`;
const hours = Math.floor(minutes / 60);
return `${hours}h ago`;
}
Loading
Loading