Fix some undefined behavior#1
Open
hvenev-insait wants to merge 2 commits intodime10:masterfrom
Open
Conversation
filteredTypes is local to filterRegSize and gets destroyed at the end of the function. Returning a TypeRange on it is UB, so return it by value instead.
It looks like temporaries in the range-expression get destroyed after it's evaluated. In this case the range-expression is a call to `Optional::operator*` that returns a reference to the Optional's inner value, but the Optional itself is a temporary. Fix this by assigning the value inside the optional to a variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my machine one of the
quantum-opttests crashes:With these changes the tests pass with AddressSanitizer and UndefinedBehaviorSanitizer enabled.