Skip to content

Conversation

@spomichter
Copy link
Contributor

Summary

  • probe a set of user-writable directories before selecting the JSON log destination and fall back when the project root is read-only
  • gracefully disable file logging with a warning when no writable directory can be created
  • keep setup_logger compatible with existing call sites that pass a logger name string

Testing

  • python -m compileall dimos/utils/logging_config.py

Codex Task

Base automatically changed from improve-logging to dev December 3, 2025 09:41
spomichter and others added 28 commits December 22, 2025 18:40
…mplemented

Modules navigate object bbox

Changes:
- Created BBox navigator to take in Detection2D type and output goal pose
- Extracted from object tracker 2d and 3d object trackers. 2d tested. 3d not yet tested. 
- Remove navigate_to_object method that should not be in the unitree runfile 

To run: 
`python dimos/robot/unitree_webrtc/run_agents2.py`

To give agent input: 
`human-cli`

Former-commit-id: 97ad579 [formerly 499c151]
Former-commit-id: 2206497
Former-commit-id: 29dd30f [formerly 781fe65]
Former-commit-id: 02785e0
* g1 switched over to webcam module

* camera system cleanup, calibration loading

* zed calibration file

* removed comments / unused imports from zed

* integration wip

* universal camera module

* fixed flakey test_reactive test

* removed obsolete test

* print cleanup

* topic change for bridge, small camera module fixes

* g1 local changes

* ros global map

* height filter config for module3d

* splitting types, object db work

* circular imports solved

* foxglove sceneupdate

* pointcloud bounding box intersection, detection3d projection refactor

* checkpoint

* detection work snapshot

* testing refactor

* good replay example

* bugfixes, improvements, g1 compatibilty

* working on universal recorder

* recorder cli

* onboard g1 changes and recording

* corrected timestamp alignment

* temporary nav integration

* color hash type, timestamp alignment fix

* new timestamp alignment

* timed replay refactor

* correct detected image broadcast from module2d

* better dict repr

* g1 replay system

* g1 filters

* weaklist

* raycast bugfix

* small bugfixes

* agent integration to unitree_go2

* TOFIX double pub goal message for reliability

* fix

* cam fix

* added joy message type to dimos

* added set autonomy mode

* added joy to ros bridge

* fixed

* CI code cleanup

* Fully working G1 ros navigation to origin

* g1 agents2 spatial navigation

* CI code cleanup

* comment out camera image

* fix

* commit

* adapt

* image

* crop image

* switch back to old camera

* sharpness window generalized to quality_barrier

* tests consolidation, preparing for merge

* tests fix

* qwen localization

* nav to object in view

* forgot init

* bugfix

* bugfix

* fix for timestamp on g1

* killing time stuff

* quick fixes

* onboard unitree changes

* CI code cleanup

* moduledb hack

* moduledb hack

* current g1

* quaternion fix

* Re enabled detections, removed go to origin on startup

* Fully working save location and navigate to saved location

* Fully working G1 spatial memory, detections, location saving on agents2

* Fully working G1 webrtc skills integrated as SkillContainer module for agents2

* foxglove vis for 3d localization

* fixing tests

* tests fix

* fixing detection tests

* checkpoint

* fixing detection tests

* tf issue

* allowing tf autostart

* objectdb test

* threading bugfix

* syntax error fix

* import error fix

* nav skill fix

* PR comments

* missing numpy import

* qwen converter bugfix

* Fix import np

---------

Co-authored-by: alexlin2 <alex.lin416@outlook.com>
Co-authored-by: alexlin2 <44330195+alexlin2@users.noreply.github.com>
Co-authored-by: Paul Nechifor <paul@nechifor.net>
Co-authored-by: paul-nechifor <1262969+paul-nechifor@users.noreply.github.com>
Co-authored-by: Stash Pomichter <pomichterstash@gmail.com>
Former-commit-id: e727499 [formerly c0d886b]
Former-commit-id: a8a1818
Former-commit-id: c0b69b2 [formerly e08fb2b]
Former-commit-id: a9a2a0f
Update README.md

Former-commit-id: cfb62c5 [formerly e999a38]
Former-commit-id: fecd63b
Former-commit-id: 6858e17 [formerly c1385dc]
Former-commit-id: d7f243e
Former-commit-id: 76d02e8 [formerly 71c19cb]
Former-commit-id: bcbb347
Former-commit-id: 7d319c3 [formerly 5458064]
Former-commit-id: 44203ab
Former-commit-id: a622bde [formerly 8fa3e80]
Former-commit-id: f452d04
Former-commit-id: cd2f67b [formerly 0685a85]
Former-commit-id: 94b43d8
Former-commit-id: 84a6ce1 [formerly d0dbcbb]
Former-commit-id: 3e702a4
Former-commit-id: 60f613f [formerly 702c8e8]
Former-commit-id: e0f042c
Former-commit-id: da4142e [formerly 0dd8344]
Former-commit-id: 2120b2d
Image upgrades! Impls for CUDA + numpy, along with an abstraction and full backwards compatibility

Former-commit-id: 967b376 [formerly 42f410f]
Former-commit-id: 9fabab7
…tion and full backwards compatibility"

Former-commit-id: fbc5ef7 [formerly fcd8f84]
Former-commit-id: d03de8a
…ades

Revert "Image upgrades! Impls for CUDA + numpy, along with an abstraction and full backwards compatibility"

Former-commit-id: 44ade7b [formerly 3efa77d]
Former-commit-id: 69ab836
…ction and full backwards compatibility"

This reverts commit fab1422 [formerly d03de8a] [formerly fbc5ef7 [formerly fcd8f84]].


Former-commit-id: ba4632d [formerly cdfaaed]
Former-commit-id: 5c66f2a
Former-commit-id: 40981a5 [formerly 2924852]
Former-commit-id: e741997
Former-commit-id: afeae2d [formerly 2a017dc]
Former-commit-id: 0eb7449
Former-commit-id: fdefb17 [formerly 15d1991]
Former-commit-id: 40ff144
Former-commit-id: 015f4cd [formerly e886217]
Former-commit-id: 2e47a4c
Former-commit-id: fc06607 [formerly 3ba5695]
Former-commit-id: b21cb36
* g1 switched over to webcam module

* camera system cleanup, calibration loading

* zed calibration file

* removed comments / unused imports from zed

* integration wip

* universal camera module

* fixed flakey test_reactive test

* removed obsolete test

* print cleanup

* topic change for bridge, small camera module fixes

* g1 local changes

* ros global map

* height filter config for module3d

* splitting types, object db work

* circular imports solved

* foxglove sceneupdate

* pointcloud bounding box intersection, detection3d projection refactor

* checkpoint

* detection work snapshot

* testing refactor

* good replay example

* bugfixes, improvements, g1 compatibilty

* working on universal recorder

* recorder cli

* onboard g1 changes and recording

* corrected timestamp alignment

* temporary nav integration

* color hash type, timestamp alignment fix

* new timestamp alignment

* timed replay refactor

* correct detected image broadcast from module2d

* better dict repr

* g1 replay system

* g1 filters

* weaklist

* raycast bugfix

* small bugfixes

* agent integration to unitree_go2

* TOFIX double pub goal message for reliability

* fix

* cam fix

* added joy message type to dimos

* added set autonomy mode

* added joy to ros bridge

* fixed

* CI code cleanup

* Fully working G1 ros navigation to origin

* g1 agents2 spatial navigation

* CI code cleanup

* comment out camera image

* fix

* commit

* adapt

* image

* crop image

* switch back to old camera

* sharpness window generalized to quality_barrier

* tests consolidation, preparing for merge

* tests fix

* qwen localization

* nav to object in view

* forgot init

* bugfix

* bugfix

* fix for timestamp on g1

* killing time stuff

* quick fixes

* onboard unitree changes

* CI code cleanup

* moduledb hack

* moduledb hack

* current g1

* quaternion fix

* Re enabled detections, removed go to origin on startup

* Fully working save location and navigate to saved location

* Fully working G1 spatial memory, detections, location saving on agents2

* Fully working G1 webrtc skills integrated as SkillContainer module for agents2

* foxglove vis for 3d localization

* cleaning up detection2d

* added detic

* detic

* pose detector sketch

* restructure

* pose -> person

* person detector sketch

* yolo pose test

* separated detection3d and detection3dpc

* object3d new test

* lcm replay test

* thread cleanup

* added seek for example

* deactivate detic

* detection3d bugfix

* fixing tests 1

* fixing tests

* wavefront explorer smaller costmap for faster testing

* person detector merged with follower spec

* fixing tests, timestamp alignment threading

* people annotations test fix

* removed recorder, moved qewen from dev

* fixing tests

* tests passing now

* indeterministic test fix

* removing temp file

* bugfix

* Update dimos/perception/detection2d/detectors/detic.py

Co-authored-by: Paul Nechifor <paul@nechifor.net>

---------

Co-authored-by: alexlin2 <alex.lin416@outlook.com>
Co-authored-by: alexlin2 <44330195+alexlin2@users.noreply.github.com>
Co-authored-by: Paul Nechifor <paul@nechifor.net>
Co-authored-by: paul-nechifor <1262969+paul-nechifor@users.noreply.github.com>
Co-authored-by: Stash Pomichter <pomichterstash@gmail.com>
Former-commit-id: aff4902 [formerly 66440ab]
Former-commit-id: 28a0f4f
Former-commit-id: 578082e [formerly f91d6e2]
Former-commit-id: 3d39b97
Former-commit-id: 0ddb162 [formerly 820fa59]
Former-commit-id: 342e16c
Former-commit-id: 9c4d08c [formerly 348d49c]
Former-commit-id: 861cee3
paul-nechifor and others added 17 commits December 26, 2025 16:36
Former-commit-id: f7114d1 [formerly ae01fbb]
Former-commit-id: 5df3e70
Former-commit-id: d967744 [formerly e0e631e]
Former-commit-id: fe75197
…s / cleanup

### detections
- bugfixes on detection stuff for precise bounding boxes, independant human skeleton tracking and static object tracking

### unitree general rewrite
- moved my stuff from unitree_webrtc/ to just unitree/, removed old unitree/ dir completely
- rewrote the structure, simplified minimal run files

### unitree go2 rewrite
- lots of nuts things, fixed, system load down from 13 to 3 now for me, runs very well

### modular run files, no robot deps
- more to do here, very quick minimal first pass

### brutalized nav skills
- I kinda beat this into submission to not depend on robot, it's not great, I'd consider it needing a full revisit and a second PR, IMO lots has changed and it's ok to rewrite

### rosnav
- throttling of lidar frames (was high frequency, high bandwidth and had issues with remote foxglove, possibly can bump up once images are jpeg if we need to
- standard configuration 
- removed boolean topics to conform to spec (can discuss)
- added some basic skills, passive stream for global position, relative movement, and absolute movement skills

### testing
```sh
cd dimos/robot/unitree 
python run.py --ip mujoco go2/go2.py
python run.py --ip mujoco g1/g1detector.py # or any other
```

Former-commit-id: 9170349 [formerly 3fc3b02]
Former-commit-id: 6ae0290
Former-commit-id: df48bb0 [formerly 4364eb3]
Former-commit-id: 5c98b9c
Former-commit-id: e777e51 [formerly 4fe4321]
Former-commit-id: fdd751e
Remove depth module from base unitree go2 blueprints

Former-commit-id: 31a52ee [formerly 35138c4]
Former-commit-id: 99f9eb7
Former-commit-id: 3b8b39d [formerly 51ac68e]
Former-commit-id: f28b472
Former-commit-id: ef046bc [formerly a64c477]
Former-commit-id: c5b447c
Former-commit-id: 0eaa934 [formerly 7c2f3c3]
Former-commit-id: e53435c
Former-commit-id: b278570 [formerly d684d00]
Former-commit-id: 902a959
Former-commit-id: 396062f [formerly e8ab7d0]
Former-commit-id: f9c1d7c
Former-commit-id: d6d5517 [formerly d0f1639]
Former-commit-id: 9ee842d
Fix Unitree Go2 (replay and spatial memory)

Former-commit-id: 437b311 [formerly 0875fbc]
Former-commit-id: bcc663f
Former-commit-id: c9bf02b [formerly 22488d5]
Former-commit-id: a21427d
Former-commit-id: f37c12a [formerly 54794df]
Former-commit-id: 33e22d8
Former-commit-id: e25b107
Former-commit-id: 10ab813
Former-commit-id: acb172e
Former-commit-id: 9c09d6a
@spomichter spomichter force-pushed the codex/github-mention-use-structlog-and-store-json-logs-on-disk branch from acb172e to 9c09d6a Compare January 8, 2026 13:59
@spomichter spomichter requested a review from a team January 8, 2026 13:59
@greptile-apps
Copy link

greptile-apps bot commented Jan 8, 2026

Too many files changed for review.

1 similar comment
@greptile-apps
Copy link

greptile-apps bot commented Jan 8, 2026

Too many files changed for review.

Former-commit-id: 0a8a5a7
@greptile-apps
Copy link

greptile-apps bot commented Jan 8, 2026

Too many files changed for review.

@spomichter spomichter force-pushed the codex/github-mention-use-structlog-and-store-json-logs-on-disk branch from 0a8a5a7 to 4591397 Compare January 8, 2026 22:59
@greptile-apps
Copy link

greptile-apps bot commented Jan 8, 2026

Too many files changed for review.

@spomichter spomichter force-pushed the codex/github-mention-use-structlog-and-store-json-logs-on-disk branch from 4591397 to 5d14ce9 Compare January 8, 2026 23:18
@greptile-apps
Copy link

greptile-apps bot commented Jan 8, 2026

Too many files changed for review.

1 similar comment
@greptile-apps
Copy link

greptile-apps bot commented Jan 8, 2026

Too many files changed for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants