Change query::visitors::*Collector to visitors#296
Open
z33ky wants to merge 2 commits intodimforge:masterfrom
Open
Change query::visitors::*Collector to visitors#296z33ky wants to merge 2 commits intodimforge:masterfrom
z33ky wants to merge 2 commits intodimforge:masterfrom
Conversation
Instead of allocating a Vec to put the query results in, the Collectors are changed to call a visitor instead. If the call-site does want a Vec, they can easily collect themselves. We ourselves do not actually need this, so we can remove a couple of Vecs and corresponding allocations for some operations. The *Collectors are also appropriately renamed to *Visitor.
Contributor
Author
|
I've missed explaining the motivation for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the old *Collectors are removed, this is an API-breaking change.
They could easily be re-added on top of the Visitors though.